Fixes for Windows #2790
Merged
Fixes for Windows #2790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
foldl
commented
Feb 5, 2025
foldl
commented
- MSVC default to utf-8 without BOM.
- Console output code page changed to utf-8.
added 2 commits
February 5, 2025 14:42
* MSVC default to utf-8 without BOM. * Console output code page changed to utf-8.
ggerganov
approved these changes
Feb 5, 2025
Closed
ggerganov
reviewed
Feb 5, 2025
Comment on lines
+45
to
+46
| add_compile_options("$<$<COMPILE_LANGUAGE:C>:/utf-8>") | ||
| add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:/utf-8>") |
There was a problem hiding this comment.
Btw, which source files require this flag? I am wondering because in llama.cpp we don't seem to need this.
There was a problem hiding this comment.
whisper.cpp requires this flag:
There are such flags in llama.cpp:
joelvaneenwyk
pushed a commit
to joelvaneenwyk/whisper-cpp
that referenced
this pull request
Mar 3, 2025
Fixes for Windows: * MSVC default to utf-8 without BOM. * Console output code page changed to utf-8. --------- Co-authored-by: Judd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.